Fix a bug in extract_best_per_route kernel#156
Merged
rapids-bot[bot] merged 2 commits intoNVIDIA:branch-25.08from Jun 27, 2025
Merged
Fix a bug in extract_best_per_route kernel#156rapids-bot[bot] merged 2 commits intoNVIDIA:branch-25.08from
rapids-bot[bot] merged 2 commits intoNVIDIA:branch-25.08from
Conversation
rg20
added
bug
Contributor
Author
|
/ok to test e5ff891 |
hlinsen
approved these changes
Jun 27, 2025
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The mentioned kernel does not require any dynamic shared memory, however, we are passing
sh_sizethat is relevant for the previous kernel in the code. In most cases it is fine. However, if the sh_size is more than the shared memory available, the kernel fails to launch withcudaInvalidValueerror. The previous kernel has no issues because the dynamic shared memory is tuned for that kernel usingcudaFuncSetAttributecall.This PR passes zero as the dynamic shared size to resolve the issue.
Issue
This is a bug reported by a customer.
Checklist